Optimizing Boolean Logic

1#include <iostream>
2using namespace std;
3
4int main() {
5  bool isAlive{true};
6  bool hasWeapon{false};
7  bool isInCombat{true};
8  bool hasMagic{true};
9
10  // Bad order - checks everything even when
11  // isAlive is false
12  bool canFight{
13    hasWeapon && isAlive && isInCombat}; 
14
15  // Better order - stops checking if
16  // isAlive is false
17  bool canFightOptimized{
18    isAlive && hasWeapon && isInCombat}; 
19
20  cout << "Can fight: " << canFightOptimized;
21}

1#include <iostream>
2using namespace std;
3
4int main() {
5  bool isAlive{true};
6  bool hasWeapon{true};
7  bool hasMagic{true};
8  bool hasAmmo{false};
9  bool hasMana{true};
10
11  // Hard to understand at a glance 
12  bool canAttack{
13    isAlive && hasWeapon && hasAmmo
14    || hasMagic && hasMana};
15
16  // Clearer grouping makes the logic obvious 
17  bool canAttackClearer{
18    isAlive && (
19      (hasWeapon && hasAmmo) ||
20      (hasMagic && hasMana)
21    )};
22
23  cout << "Can attack: " << canAttackClearer;
24}

1#include <iostream>
2using namespace std;
3
4int main() {
5  bool isAlive{true};
6  bool hasWeapon{true};
7  bool hasMagic{true};
8  bool hasAmmo{false};
9  bool hasMana{true};
10  int Level{5};
11
12  // Break down complex conditions into parts
13  bool hasPhysicalAttack{hasWeapon && hasAmmo};
14  bool hasMagicalAttack{hasMagic && hasMana};
15  bool meetsLevelRequirement{Level >= 5};
16
17  bool canAttack{
18    isAlive && meetsLevelRequirement &&
19    (hasPhysicalAttack || hasMagicalAttack)
20  };
21
22  cout << "Can attack: " << canAttack;
23}